Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Persuasion Rack Bugs #1591

Merged
merged 5 commits into from
Apr 12, 2024
Merged

Fix Persuasion Rack Bugs #1591

merged 5 commits into from
Apr 12, 2024

Conversation

Bastian0930
Copy link
Contributor

@Bastian0930 Bastian0930 commented Apr 6, 2024

Prevents basicmob torture, while also preventing the user from spamming the rack (which would make them lose a lot of blood)

About The Pull Request

Prevents basicmob torture, while also preventing the user from spamming the rack (which would make them lose a lot of blood).

Why It's Good For The Game

Spamming the rack to instantly lose all of your blood does not seem intended, and seems very harmful. Also, based on the other people you're allowed to torture, I don't think you were supposed to be able to torture simplemobs in the first place.

If you were supposed to be able to torture basic mobs, tell me, and I can fix that.

Changelog

🆑
fix: Bloodsuckers are unable to spam click the persuasion rack and lose all their blood, as part of the new clan training.
fix: Bloodsuckers will not torture basic mobs or animals, after a clan agreement involving the Animal Rights Consortium.
/:cl:

Prevents basicmob torture, while also preventing the user from spamming the rack (which would make them lose a lot of blood)
@Bastian0930
Copy link
Contributor Author

By the way, regarding the basic mob torture, that was another fix. For some reason, torturing them would instantly skip the bar and just instantly vassalize them. It seems like they were forgotten, leading me to believe they probably were not meant to be tortured.

…t words.

suggested by maintainer, changed it because I see no reason not to.

plus looks nicer!!
@dwasint dwasint merged commit a3597d1 into Monkestation:master Apr 12, 2024
20 checks passed
github-actions bot added a commit that referenced this pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants